Skip to content

fix(cli): do not include buffers/cache for host memory used #8095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix(cli): do not include buffers/cache for host memory used #8095

merged 1 commit into from
Jun 20, 2023

Conversation

johnstcn
Copy link
Member

No description provided.

@johnstcn johnstcn requested review from matifali and mtojek June 20, 2023 12:21
@johnstcn johnstcn self-assigned this Jun 20, 2023
mtojek
mtojek approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you please link it with #8091?

@johnstcn
Copy link
Member Author

Thanks!

Could you please link it with #8091?

Different issue :-)

@johnstcn johnstcn changed the title fix(clistat): do not include buffers/cache for host memory used fix(clistat/stat.go): do not include buffers/cache for host memory used Jun 20, 2023
@johnstcn johnstcn changed the title fix(clistat/stat.go): do not include buffers/cache for host memory used fix(cli): do not include buffers/cache for host memory used Jun 20, 2023
@johnstcn johnstcn merged commit 0f754f0 into main Jun 20, 2023
@johnstcn johnstcn deleted the cj/coder-stat-mem-fix branch June 20, 2023 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
matifali
matifali reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@matifali matifali linked an issue Jun 20, 2023 that may be closed by this pull request
bug: dogfood template RAM usage using coder stat ram --host is different from htop #8094
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: dogfood template RAM usage using coder stat ram --host is different from htop
3 participants
@johnstcn @matifali @mtojek