Skip to content

chore: add more rules to ensure logs consistency #8104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jun 20, 2023

Related: #6726

This PR extends linting rules to cover <foo>.logger.<method> cases. Apparently, current rules miss lines where the logger was a field of a structure.

@mtojek mtojek self-assigned this Jun 20, 2023
@mtojek mtojek requested a review from mafredri June 20, 2023 15:26
@mtojek mtojek marked this pull request as ready for review June 20, 2023 15:26
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would still suggest changing all instances of can't [thing] to either unable to [thing], [thing] failed or similar.

(PS. Odd, I could've sworn I submitted this PR review yesterday already ¯\_(ツ)_/¯.)

@mtojek mtojek merged commit 4fb4c9b into main Jun 21, 2023
@mtojek mtojek deleted the 6726-more-rules branch June 21, 2023 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants