Skip to content

chore: restyle provisioner job output format #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

chore: restyle provisioner job output format #8106

merged 1 commit into from
Jun 20, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 20, 2023 •
edited
Loading

Reduce colors and formatting to reduce bugs and increase UNIX feel.

When I initially made this, I tried it make it pretty, but it was just buggy, and I'm not sure anyone wants pretty.

New output:

dev ~/p/c/coder (mergegen *s =) go run ./cmd/cliui job
==> ⧗ Queued
Some log 0
Some log 1
Some log 2
Some log 3
Some log 4
Some log 5
Some log 6
Some log 7
Some log 8
Some log 9
=== ✔ Queued [1100ms]
==> ⧗ Setting Up
Some log 11
Some log 12
Some log 13
Some log 14
Some log 15
Some log 16
Some log 17
Some log 18
Some log 19
=== ✔ Setting Up [1000ms]
==> ⧗ Executing Hook
Some log 21
Some log 22
Some log 23
Some log 24
Some log 25
Some log 26
Some log 27
Some log 28
Some log 29
=== ✔ Executing Hook [1000ms]
==> ⧗ Parsing Variables
Some log 31
Some log 32
Some log 33
Some log 34
Some log 35
Some log 36
Some log 37
Some log 38
=== ✔ Parsing Variables [899ms]

@kylecarbs
chore: restyle provisioner job output format
a57de37 
Reduce colors and formatting to reduce bugs and increase UNIX-feel.
@kylecarbs kylecarbs requested review from mafredri and ammario June 20, 2023 15:29
@kylecarbs kylecarbs self-assigned this Jun 20, 2023
@kylecarbs kylecarbs enabled auto-merge (squash) June 20, 2023 15:34
mafredri
mafredri approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good approach!

Are we fine with agent events looking the same (#7767)?

==> ⧗ Waiting for workspace agent to connect
=== ✔ Waiting for workspace agent to connect [5000ms]
==> ⧗ Running workspace agent startup script
...
=== ✔ Running workspace agent startup script [12000ms]

We've previously had the spinner but I think there's value in making the feel unified.

@kylecarbs
Copy link
Member Author

Yup, I think that's great!

@kylecarbs
Copy link
Member Author

BTW I'm not attached to this format... so suggestions are welcome!

@kylecarbs kylecarbs merged commit 467b0a1 into main Jun 20, 2023
@kylecarbs kylecarbs deleted the jobfmt branch June 20, 2023 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@ammario ammario ammario approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @mafredri @ammario