chore(site): remove new filter from experimental

coder · BrunoQuaresma · Jun 21, 2023 · Jun 20, 2023 · Jun 20, 2023 · Jun 21, 2023
commit d0b0f04a99ba3db047751676f4e74c91fd65d86e
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -1704,9 +1704,6 @@ const (
 	// https://github.com/coder/coder/milestone/19
 	ExperimentWorkspaceActions Experiment = "workspace_actions"
 
-	// New workspace filter
-	ExperimentWorkspaceFilter Experiment = "workspace_filter"
-
 	// Add new experiments here!
 	// ExperimentExample Experiment = "example"
 )
@@ -1715,9 +1712,7 @@ const (
 // users to opt-in to via --experimental='*'.
 // Experiments that are not ready for consumption by all users should
 // not be included here and will be essentially hidden.
-var ExperimentsAll = Experiments{
-	ExperimentWorkspaceFilter,
-}
+var ExperimentsAll = Experiments{}
 
 // Experiments is a list of experiments that are enabled for the deployment.
 // Multiple experiments may be enabled at the same time.

diff --git a/docs/api/schemas.md b/docs/api/schemas.md
@@ -2490,7 +2490,6 @@ AuthorizationObject can represent a "set" of objects, such as: all workspaces in
 | ------------------- |
 | `moons`             |
 | `workspace_actions` |
-| `workspace_filter`  |
 
 ## codersdk.Feature
 

diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -1342,12 +1342,8 @@ export const Entitlements: Entitlement[] = [
 ]
 
 // From codersdk/deployment.go
-export type Experiment = "moons" | "workspace_actions" | "workspace_filter"
-export const Experiments: Experiment[] = [
-  "moons",
-  "workspace_actions",
-  "workspace_filter",
-]
+export type Experiment = "moons" | "workspace_actions"
+export const Experiments: Experiment[] = ["moons", "workspace_actions"]
 
 // From codersdk/deployment.go
 export type FeatureName =

diff --git a/site/src/components/Filter/filter.tsx b/site/src/components/Filter/filter.tsx
@@ -74,6 +74,8 @@ export const useFilter = ({
   }
 }
 
+export type UseFilterResult = ReturnType<typeof useFilter>
+
 const parseFilterQuery = (filterQuery: string): FilterValues => {
   if (filterQuery === "") {
     return {}

diff --git a/site/src/components/Filter/menu.ts b/site/src/components/Filter/menu.ts
@@ -101,3 +101,5 @@ export const useFilterMenu = <TOption extends BaseOption = BaseOption>({
     isSearching: searchOptionsQuery.isFetching,
   }
 }
+
+export type UseFilterMenuResult = ReturnType<typeof useFilterMenu>
diff --git a/site/src/components/Filter/storyHelpers.ts b/site/src/components/Filter/storyHelpers.ts
@@ -0,0 +1,34 @@
+import { action } from "@storybook/addon-actions"
+import { UseFilterResult } from "./filter"
+import { UseFilterMenuResult } from "./menu"
+
+export const MockMenu: UseFilterMenuResult = {
+  initialOption: undefined,
+  isInitializing: false,
+  isSearching: false,
+  query: "",
+  searchOptions: [],
+  selectedOption: undefined,
+  selectOption: action("selectOption"),
+  setQuery: action("updateQuery"),
+}
+
+export const getDefaultFilterProps = <TFilterProps>({
+  query = "",
+  values,
+  menus,
+}: {
+  query?: string
+  values: Record<string, string | undefined>
+  menus: Record<string, UseFilterMenuResult>
+}) =>
+  ({
+    filter: {
+      query,
+      update: () => action("update"),
+      debounceUpdate: action("debounce") as UseFilterResult["debounceUpdate"],
+      used: false,
+      values,
+    },
+    menus,
+  } as TFilterProps)
diff --git a/site/src/components/SearchBarWithFilter/SearchBarWithFilter.stories.tsx b/site/src/components/SearchBarWithFilter/SearchBarWithFilter.stories.tsx
diff --git a/site/src/components/SearchBarWithFilter/SearchBarWithFilter.test.tsx b/site/src/components/SearchBarWithFilter/SearchBarWithFilter.test.tsx
-Original file line number
+Diff line change
@@ Expand Up @@
         isSearching: searchOptionsQuery.isFetching,
       }
     }
+    export type UseFilterMenuResult = ReturnType<typeof useFilterMenu>