feat(codersdk/agentsdk): add StartupLogsSender and StartupLogsWriter
#8129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StartupLogsSender and StartupLogsWriterStartupLogsSender and StartupLogsWriter
6b97ede to
8ce4e7d
Compare
This commit adds two new `agentsdk` functions, `StartupLogsSender` and `StartupLogsWriter` that can be used by any client looking to send startup logs to coderd. We also refactor the `agent` to use these new functions. As a bonus, agent startup logs are separated into "info" and "error" levels to separate stdout and stderr.
8ce4e7d to
5e48ee1
Compare
mafredri
commented
Jun 21, 2023
| }() | ||
|
|
||
| var queue []StartupLog | ||
| sendLog = func(callCtx context.Context, log ...StartupLog) error { |
There was a problem hiding this comment.
Review: Technically we don't need callCtx here right now because we allow the queue/backlog to grow without bounds, but if we need to limit this in the future, accepting a context here makes it much nicer for the user of the SDK, letting them abort if it takes too long.
ec496f8 to
cdb64e2
Compare
mafredri
commented
Jun 21, 2023
| "github.com/coder/retry" | ||
| ) | ||
|
|
||
| type startupLogsWriter struct { |
There was a problem hiding this comment.
Review: I went a round of back-and-forth on making this concurrently safe. Ultimately I opted to revert the concurrency safety in favor of keeping the implementation as short/simple as possible (cdb64e2 (#8129)).
6435f12 to
9ac5d60
Compare
mtojek
approved these changes
Jun 22, 2023
mtojek
reviewed
Jun 22, 2023
Co-authored-by: Marcin Tojek <mtojek@users.noreply.github.com>
|
Related: #7767 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #8084 (note that the implementation had to change slightly to accommodate the additional use-case):
This commit adds two new
agentsdkfunctions,StartupLogsSenderandStartupLogsWriterthat can be used by any client looking to sendstartup logs to coderd.
We also refactor the
agentto use these new functions.As a bonus, agent startup logs are separated into "info" and "error"
levels to separate stdout and stderr.