Skip to content

feat: add --disable-direct-connections flag to CLI #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2023
Merged

feat: add --disable-direct-connections flag to CLI #8131

merged 5 commits into from
Jun 21, 2023

Conversation

deansheather
Copy link
Member

Adds global flag --disable-direct to CLI which forces all CLI connections to workspaces to be proxied through DERP.

Closes #7179

kylecarbs
kylecarbs reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable-direct as a name isn't clear when you aren't aware of our direct connections via DERP terminology. I might say disable-direct-connections or something like it would be better.

@deansheather
Copy link
Member Author

sure!

coadler
coadler approved these changes Jun 21, 2023
View reviewed changes
@deansheather deansheather enabled auto-merge (squash) June 21, 2023 20:06
@deansheather deansheather merged commit 24b95e1 into main Jun 21, 2023
@deansheather deansheather deleted the dean/disable-direct-cli branch June 21, 2023 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@deansheather deansheather changed the title feat: add --disable-direct flag to CLI feat: add --disable-direct-connections flag to CLI Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client configuration to disable STUN
3 participants
@deansheather @coadler @kylecarbs