Skip to content

feat: add user search query param on last_seen #8139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 21, 2023

Closes #7901

Example Query:

last_seen_before:"2023-01-14T23:59:59Z" last_seen_after:"2023-01-08T00:00:00Z"

Notes

Uses RFC3339Nano format (2006-01-02T15:04:05.999999999Z07:00) which we used for our other endpoints.

The feature works, but there is a matter of usability that could be improved. Such as last_seen_after:yesterday or last_seen_after:-24hr, etc.

We can add better usability later if this ends up being used frequently. The usability can happen on the FE or BE.

@Emyrk Emyrk requested a review from deansheather June 22, 2023 15:41
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Emyrk Emyrk merged commit f56db1b into main Jun 22, 2023
@Emyrk Emyrk deleted the stevenmasley/user_last_seen branch June 22, 2023 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to filter users by inactivity
2 participants