Skip to content

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 21, 2023

This sets a solid framework for doing more in the future as well... it's extremely easy to add more tests with complex scenarios. The tests look extremely similar to the Go tests, which should allow backend devs to contribute easily!

They should scale well, too, because creating a workspace doesn't provide infrastructure... it's essentially mocked using the echo provisioner.

@kylecarbs kylecarbs requested review from BrunoQuaresma and bpmct June 21, 2023 23:17
@kylecarbs kylecarbs self-assigned this Jun 21, 2023
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FE looks good. Really nice to see a better way of provisioning a workspace for e2e testing. Thx for that.

@kylecarbs kylecarbs force-pushed the supere2e branch 2 times, most recently from 0f2d64d to 128dff2 Compare June 21, 2023 23:56
@kylecarbs kylecarbs enabled auto-merge (squash) June 22, 2023 00:11
@kylecarbs kylecarbs merged commit d434181 into main Jun 22, 2023
@kylecarbs kylecarbs deleted the supere2e branch June 22, 2023 00:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants