Skip to content

chore: add ssh disconnect log with errors #8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

chore: add ssh disconnect log with errors #8143

merged 1 commit into from
Jun 22, 2023

Conversation

spikecurtis
Copy link
Contributor

Fixes #7961

c.f. coder/ssh#4

@spikecurtis
chore: log ssh connection disconnects with errors
8fab217 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested review from mafredri and mtojek June 22, 2023 07:05
mtojek
mtojek approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@spikecurtis spikecurtis changed the title chore: adds ssh disconnect log with errors chore: add ssh disconnect log with errors Jun 22, 2023
@spikecurtis spikecurtis merged commit e738123 into main Jun 22, 2023
@spikecurtis spikecurtis deleted the spike/7961-disconnect-error branch June 22, 2023 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent SSH server should log connections including beginning, end, and reason for disconnect
3 participants
@spikecurtis @mafredri @mtojek