Skip to content

ci: delete old workflow runs #8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2023
Merged

ci: delete old workflow runs #8146

merged 5 commits into from
Jun 22, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jun 22, 2023

This cleans up old workflow runs for pr-cleanup.yaml as this action runs on every PR close event, so we have a lot of failed workflow logs as it tried to clean up every pr, and we do not have deployments for every pr.

More workflows can be added by appending to the list e.g.
delete_workflow_pattern: ["pr-deploy.yaml", "pr-cleanup.yaml"]

This cleans up old workflow runs for `pr-deply.yaml`
More workflows can be added by appending to the list
e.g.

`delete_workflow_pattern: ["pr-deploy.yaml", "pr-cleanup.yaml"]`
@matifali matifali changed the title ci : delete old workflow runs ci: delete old workflow runs Jun 22, 2023
@matifali matifali closed this Jun 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
@matifali matifali reopened this Jun 22, 2023
@matifali matifali requested a review from bpmct June 22, 2023 15:44
@ammario
Copy link
Member

ammario commented Jun 22, 2023

I find the old, failed workflows helpful when investigating flakiness and performance trends.

@matifali
Copy link
Member Author

matifali commented Jun 22, 2023

I find the old, failed workflows helpful when investigating flakiness and performance trends.

Can we only clean up for pr-cleanup.yaml?

@ammario
Copy link
Member

ammario commented Jun 22, 2023

Why do you want to cleanup at all? What bothers you about the current system?

@matifali
Copy link
Member Author

@ammario https://github.com/coder/coder/actions/workflows/pr-cleanup.yaml
This will have a failed run for every closed pr that did not have a pr deployment. If this is ok, we can close this.

@ammario
Copy link
Member

ammario commented Jun 22, 2023

Oh, I misunderstood the purpose of this PR.

@matifali matifali merged commit f4a712b into main Jun 22, 2023
@matifali matifali deleted the matifali/stale-runs branch June 22, 2023 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants