Skip to content

ci: fix wrong trigger pr-deploy.yaml #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2023
Merged

ci: fix wrong trigger pr-deploy.yaml #8151

merged 3 commits into from
Jun 22, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jun 22, 2023 •
edited
Loading

This is a hotfix to resolve a syntax issue and wrong trigger

@matifali matifali changed the title fix(ci): fix a syntax issue in pr-deploy.yaml fix(ci/pr-deploy.yaml): fix a syntax issue in pr-deploy.yaml Jun 22, 2023
cdr-bot[bot]
cdr-bot bot previously approved these changes Jun 22, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ❌ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali requested a review from bpmct June 22, 2023 15:18
@matifali matifali changed the title fix(ci/pr-deploy.yaml): fix a syntax issue in pr-deploy.yaml fix(ci/.github): fix a syntax issue in pr-deploy.yaml Jun 22, 2023
@matifali matifali changed the title fix(ci/.github): fix a syntax issue in pr-deploy.yaml chore(ci): fix a syntax issue in pr-deploy.yaml Jun 22, 2023
@matifali matifali changed the title chore(ci): fix a syntax issue in pr-deploy.yaml ci: fix a syntax issue in pr-deploy.yaml Jun 22, 2023
@matifali matifali changed the title ci: fix a syntax issue in pr-deploy.yaml ci: fix wrong trigger pr-deploy.yaml Jun 22, 2023
@matifali matifali marked this pull request as ready for review June 22, 2023 15:21
@matifali matifali removed the hotfix label Jun 22, 2023
@cdr-bot cdr-bot bot dismissed their stale review June 22, 2023 15:28

This PR is no longer a hotfix.

@matifali matifali merged commit eee4f83 into main Jun 22, 2023
@matifali matifali deleted the hotfix-pr-deployments branch June 22, 2023 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] left review comments

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @bpmct