feat(site): add change OIDC UI #8182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Jun 23, 2023
| @@ -211,6 +211,5 @@ | |||
| "go.testFlags": ["-short", "-coverpkg=./..."], | |||
| // We often use a version of TypeScript that's ahead of the version shipped | |||
| // with VS Code. | |||
| "typescript.tsdk": "./site/node_modules/typescript/lib", | |||
| "prettier.prettierPath": "./node_modules/prettier" | |||
There was a problem hiding this comment.
Why did we end up taking this out?
Kira-Pilot
reviewed
Jun 23, 2023
| @@ -20,21 +24,63 @@ export const SecurityPage: FC = () => { | |||
| }, | |||
| ) | |||
| const { error } = securityState.context | |||
| const { data: authMethods } = useQuery({ | |||
| queryKey: ["authMethods"], | |||
| queryFn: getAuthMethods, | |||
There was a problem hiding this comment.
Do we need any error handling for this query?
Kira-Pilot
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording can be updated, this feature is still hidden
FE Flow
OIDC Authenticated