feat: show service banner in SSH/TTY sessions #8186
Conversation
5a2e03f to
c16805c
Compare
f19debb to
8a13cdb
Compare
8a13cdb to
f649d3d
Compare
Otherwise there is a chance of code sneaking in between.
a4a3cbf to
e72abbb
Compare
We need to provide the banner in the test so I changed the manifest argument to support passing in the client. We could not set the banner func afterward like I was doing before because by that point the banner will already have fetched and will not update until the next interval. The test interval func also changes since I wanted to have a 15 second interval but that meant 1.5 seconds in the test which is way too long.
e72abbb to
352af1d
Compare
|
Rebased to resolve a conflict but only the new commits are affected; the original two are still the same. The banner is now polled (15 second interval at the moment). I think pushing is better but the polling seemed easier. I am open to pushing instead, just need to figure out the best way to do that. Maybe just a new endpoint and coderd iterates over workspace agents and hits that endpoint on each to update the banner? |
There was a problem hiding this comment.
I think polling is fine for now! Sorry I sent you on the wrong path with the metadata/manifest. I was under the impression we updated it periodically but it seems we usually only do it once at startup.
A few more comments but I don't think any major changes are necessary here 👍🏻
I managed to lose this in a scuffle.
Also trim to avoid adding too many newlines.
The panic might also be because you made the agent optional.
Not at all! It was still extremely useful since I was basically able to copy what we did for the manifest then just add an extra polling loop. <3 |
8add21f to
5a3d61d
Compare
5a3d61d to
6500698
Compare
|
Not entirely sure what is going on with the Datadog update step but the tests seem to be passing, at least. |
|
Awesome |
Closes #7652.