Skip to content

chore: ignore sub directories in examples for go files check #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jun 26, 2023

There are no go files in any subdirectory in the examples directory.

✅ This will prevent running any go tests when we change example templates.
⚠️ This will prevent dogfood deployment when templates are changed, as they are now included in docs-only checks.

There are no go files in any of the subdirectories in examples directory.
cdr-bot[bot]
cdr-bot bot previously approved these changes Jun 26, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ❌ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali removed the hotfix label Jun 26, 2023
@cdr-bot cdr-bot bot dismissed their stale review June 26, 2023 10:55

This PR is no longer a hotfix.

@matifali matifali merged commit b4ca285 into main Jun 26, 2023
@matifali matifali deleted the matifali/ci-go-check branch June 26, 2023 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants