feat: Compute project build parameters #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies a prior migration which is typically forbidden, but because we're pre-production deployment I felt grouping would be helpful to future contributors. This adds database functions that are required for the provisioner daemon and job queue logic.
Adds a projectparameter package to compute build-time project values for a provided scope. This package will be used to return which variables are being used for a build, and can visually indicate the hierarchy to a user.
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 71.90% 71.76% -0.14%
==========================================
Files 88 89 +1
Lines 3417 3563 +146
Branches 55 55
==========================================
+ Hits 2457 2557 +100
- Misses 751 786 +35
- Partials 209 220 +11
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // Project parameters come third! | ||
| projectParameters, err := db.GetParameterValuesByScope(ctx, database.GetParameterValuesByScopeParams{ |
There was a problem hiding this comment.
Following from the comment above - this projectParameters is a confusing name, because we use: for _, projectParameter := range projectHistoryParameters { above!
Some possible ideas:
- We could rename
projectParametershere tooverriddenProjectParameters - We could rename
projectParameterin those loops toprojectHistoryParameter
There was a problem hiding this comment.
Yup, I renamed em' all to projectHistoryParameter instead. Long name, but very clear!
Comment on lines
175
to
176
| // Validates and computes the value for parameters; setting the value on "parameterByName". | ||
| func (c *compute) inject(scopedParameters []database.ParameterValue) error { |
There was a problem hiding this comment.
Good idea to factor this out to a helper method
bryphe-coder
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a projectparameter package to compute build-time project
values for a provided scope.
This package will be used to return which variables are being
used for a build, and can visually indicate the hierarchy to
a user.