fix(cli): stat: explicitly specify resource SI prefix #8206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Jun 26, 2023
Comment on lines
+25
to
+27
| PrefixMebi = PrefixKibi * 1024.0 | ||
| PrefixGibi = PrefixMebi * 1024.0 | ||
| PrefixTebi = PrefixGibi * 1024.0 |
There was a problem hiding this comment.
These are the canonical prefix names according to NIST: https://physics.nist.gov/cuu/Units/binary.html
mafredri
approved these changes
Jun 26, 2023
| _, _ = sb.WriteString(r.Prefix.String()) | ||
| _, _ = sb.WriteString(r.Unit) | ||
|
|
||
| if r.Total != (*float64)(nil) && *r.Total > 0 { |
There was a problem hiding this comment.
Is the typed nil check really necessary here? I would expect this to be writable as r.Total != nil.
There was a problem hiding this comment.
I found it to be necessary, otherwise the unit tests fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd been attempting to automatically determine the correct SI prefix using
go-humanize, but the library doesn't provide a convenient way to scale two numbers both with a consistent prefix. Adding explicit SI prefixes instead, and defaulting toGi.