Skip to content

chore: use dogfood-oss image in .devcontainer #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 11, 2023
Merged

chore: use dogfood-oss image in .devcontainer #8231

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
15ed011
use dogfood-oss image in devcontainer
matifali Jun 17, 2023
766c7b2
fix image name
matifali Jun 17, 2023
5073517
Merge branch 'main' into matifali/devcontainer
matifali Jun 19, 2023
500d4a1
use Dockerfile
matifali Jun 19, 2023
8c02e7e
Merge remote-tracking branch 'origin/main' into matifali/devcontainer
matifali Jun 27, 2023
7fc87bf
Merge branch 'main' into matifali/devcontainer
matifali Jun 27, 2023
4809f5c
Discard changes to dogfood/Dockerfile
matifali Jun 27, 2023
32d0d14
Use features to get docker in docker
matifali Jun 28, 2023
a5331a3
Merge remote-tracking branch 'origin/main' into matifali/devcontainer
matifali Jul 3, 2023
ec35475
use previleged container
matifali Jul 3, 2023
b769b49
use codercom/oss-dogfood image
matifali Jul 4, 2023
0ad376f
Merge branch 'main' into matifali/devcontainer
matifali Jul 4, 2023
cba4ae7
Merge branch 'main' into matifali/devcontainer
matifali Jul 5, 2023
7446206
add `--priviliged` to fix GitHub Codespaces builds
matifali Jul 5, 2023
31b29fe
remove default options
matifali Jul 5, 2023
f15d298
Merge branch 'main' into matifali/devcontainer
matifali Jul 5, 2023
a5cd4cb
Merge branch 'main' into matifali/devcontainer
matifali Jul 5, 2023
b590033
Merge branch 'main' into matifali/devcontainer
matifali Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove default options
  • Loading branch information
@matifali
matifali authored Jul 5, 2023
commit 31b29fe97db818ca739a715d3894c177092fb323
7 changes: 2 additions & 5 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,8 @@
"image": "codercom/oss-dogfood:latest",

"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"version": "latest",
"enableNonRootDocker": "true",
"moby": "true"
}
// See all possible options here https://github.com/devcontainers/features/tree/main/src/docker-in-docker
"ghcr.io/devcontainers/features/docker-in-docker:2": {}
},
// SYS_PTRACE to enable go debugging
// without --priviliged the Github Codespace build fails (not required otherwise)
Expand Down