feat: add github device flow for authentication #8232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to add a GitHub OAuth provider out-of-the-box to reduce setup requirements.
4 tasks
coadler
approved these changes
Jun 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors git auth to support the GitHub OAuth device flow and adds a few nice UI features.
The short-term objective is to ship a built-in GitHub App that uses device authentication with the Coder GitHub App. This enables zero-configuration private repository clones in Coder!
The long-term objective is to private a deeper Git integration with templates allowing users to one-click integrate a repository with the Coder app and update their template automatically 🪄.
This also adds E2E tests for the device and web flows for git auth. It started to get complex, and I wanted to be very cautious of regressions with this change.
If a GitHub App is used to configure the OAuth provider, we display a button to configure it if the user has permission to read the deployment config. We also display all authorized organizations for the user (so they know where they can clone from).
A warning will be displayed if a GitHub App is used and it hasn't been installed on any organization.
If device auth is used, we display the one-time code and a button for the user to be redirected.