Skip to content

feat(site): increase max workspace lifetime TTL validation to 30 days #8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023
Merged

feat(site): increase max workspace lifetime TTL validation to 30 days #8258

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73fa9f7
feat(site): increase max workspace lifetime TTL validation to 30 days
JoshVee Jun 29, 2023
e317af5
chore(site): fix tests for change
JoshVee Jun 29, 2023
95819d3
Merge branch 'main' into JoshVee/patch-1
deansheather Jul 19, 2023
eb09071
Increase template default_ttl and max_ttl limit to 30 days
deansheather Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(site): increase max workspace lifetime TTL validation to 30 days
  • Loading branch information
@JoshVee
JoshVee authored Jun 29, 2023
commit 73fa9f71ecbd1cc929c3748501d5ff6786297ff4
4 changes: 2 additions & 2 deletions site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const Language = {
errorNoStop:
"Time until shutdown must be greater than zero when autostop is enabled.",
errorTtlMax:
"Please enter a limit that is less than or equal to 168 hours (7 days).",
"Please enter a limit that is less than or equal to 720 hours (30 days).",
daysOfWeekLabel: "Days of Week",
daySundayLabel: "Sun",
dayMondayLabel: "Mon",
Expand Down Expand Up @@ -172,7 +172,7 @@ export const validationSchema = Yup.object({
ttl: Yup.number()
.integer()
.min(0)
.max(24 * 7 /* 7 days */, Language.errorTtlMax)
.max(24 * 30 /* 30 days */, Language.errorTtlMax)
.test("positive-if-autostop", Language.errorNoStop, function (value) {
const parent = this.parent as WorkspaceScheduleFormValues
if (parent.autostopEnabled) {
Expand Down