feat: generate a new session with coder login --token #8275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure /logout does not delete the inputted token
deansheather
approved these changes
Jul 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure /logout does not delete the inputted token
Fixes #8169
I added a flag
use-token-as-sessionto do the previous behavior of using the token as the session, rather than making a new key. Figured it might be helpful in some cases, and should be possible. The workaround would be to make the auth file manually and write to it, which sounds prone to error.Notes
I removed the
deprecatedfrom CreateAPIKey because we use it in the FE and now here. This api endpoint serves a unique purpose to create "session tokens" for cli/browser auth. Until we expand the/tokensendpoint or make a new one for this case, I don't think we should deprecate it.