feat: add deleting_at column to workspaces #8333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db90772 to
9d2d583
Compare
coadler
reviewed
Jul 20, 2023
coderd/workspaces.go
Outdated
Comment on lines
788
to
800
| template, err := tx.GetTemplateByID(ctx, workspace.TemplateID) | ||
| if err != nil { | ||
| return xerrors.Errorf("get template by id: %w", err) | ||
| } | ||
|
|
||
| err = tx.UpdateWorkspaceLockedDeletingAt(ctx, database.UpdateWorkspaceLockedDeletingAtParams{ | ||
| ID: workspace.ID, | ||
| LockedAt: lockedAt, | ||
| LockedTtlMs: time.Duration(template.LockedTTL).Milliseconds(), | ||
| }) | ||
| if err != nil { | ||
| return xerrors.Errorf("update workspace locked at: %w", err) | ||
| } |
There was a problem hiding this comment.
Instead of needing to do 2 queries here, could you join templates in the UpdateWorkspaceLockedDeletingAt query?
deansheather
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
deleting_atcolumn to the workspaces table. Thedeleting_atcolumns dictates when a workspace will be permanently deleted due to inactivity. Previously the value was computed but this made it difficult to filter by on the frontend.