feat: add support for template version messages in api and cli #8336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Jul 6, 2023
| @@ -477,6 +477,7 @@ func TemplateVersion(t testing.TB, db database.Store, orig database.TemplateVers | |||
| CreatedAt: takeFirst(orig.CreatedAt, database.Now()), | |||
| UpdatedAt: takeFirst(orig.UpdatedAt, database.Now()), | |||
| Name: takeFirst(orig.Name, namesgenerator.GetRandomName(1)), | |||
| Message: orig.Message, | |||
There was a problem hiding this comment.
nit: what about testing? do we need a random message generated for unit tests or maybe benchmarks in the future?
There was a problem hiding this comment.
It's a valid concern, although I didn't do it because I'm sure how we'd set an empty message if we use takeFirst here on a randomly generated one.
There was a problem hiding this comment.
@mafredri the empty takeFirst is such an annoying problem 😢
Good observation! Yes, I'd say we do. And that means I should add detection for newlines when informing about message too long. |
058504d to
5bee51f
Compare
mafredri
commented
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for template version messages on the backend
and for the CLI commands
template createandtemplate push.Fixes the backend and CLI part of #3775