Skip to content

refactor(cli)!: move scaletest to exp/scaletest #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2023
Merged

refactor(cli)!: move scaletest to exp/scaletest #8339

merged 2 commits into from
Jul 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 6, 2023 •
edited
Loading

  • Creates a new hidden exp subcommand
  • Moves the scaletest commands under exp
  • Updates existing invocations

Fixes #7856

@johnstcn johnstcn self-assigned this Jul 6, 2023
@johnstcn johnstcn changed the title refactor(cli): mv scaletest exp/scaletest refactor(cli): move scaletest to exp/scaletest Jul 6, 2023
@johnstcn johnstcn requested review from mafredri and mtojek July 6, 2023 14:09
@johnstcn johnstcn marked this pull request as ready for review July 6, 2023 14:09
mafredri
mafredri approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mafredri
Copy link
Member

mafredri commented Jul 6, 2023

Should we mark this breaking since we're moving a non-exp command?

@johnstcn johnstcn changed the title refactor(cli): move scaletest to exp/scaletest refactor(cli)!: move scaletest to exp/scaletest Jul 6, 2023
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jul 6, 2023
@johnstcn
Copy link
Member Author

johnstcn commented Jul 6, 2023

Should we mark this breaking since we're moving a non-exp command?

I suppose yes, it technically is!

@johnstcn johnstcn merged commit 435c67a into main Jul 7, 2023
@johnstcn johnstcn deleted the cj/scaletest-exp branch July 7, 2023 08:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move scaletest into coder exp
2 participants
@johnstcn @mafredri