Skip to content

feat: Add user scoped git ssh keys #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 6, 2022
Merged

feat: Add user scoped git ssh keys #834

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
016a6a9
feat: Add user scoped git ssh keys
f0ssel Apr 1, 2022
e3c0950
tie up cli
f0ssel Apr 1, 2022
7b2b5ef
typo
f0ssel Apr 1, 2022
3b1145b
pr comments
f0ssel Apr 4, 2022
91e8435
fix queries
f0ssel Apr 4, 2022
56c6437
add gitsshkeys queries
f0ssel Apr 4, 2022
8e6ca2f
rm
f0ssel Apr 4, 2022
214bb41
make gen
f0ssel Apr 4, 2022
66ce653
make gen 2
f0ssel Apr 4, 2022
6a10a3c
add agent route
f0ssel Apr 4, 2022
f755cdb
add agent route
f0ssel Apr 4, 2022
45dc1fb
add tests for gitsshkey package
f0ssel Apr 5, 2022
ab87f12
add gitsshkey coderd tests
f0ssel Apr 5, 2022
c7b81cc
fix proto
f0ssel Apr 5, 2022
fc4fad5
lint
f0ssel Apr 5, 2022
6c83c54
pr comments
f0ssel Apr 5, 2022
c265a3c
change regenerate to a PUT method
f0ssel Apr 5, 2022
89bf77c
Fix codersdk
f0ssel Apr 5, 2022
f310c71
pr comments
f0ssel Apr 6, 2022
dee1968
fix
f0ssel Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tie up cli
  • Loading branch information
@f0ssel
f0ssel committed Apr 4, 2022
commit e3c095024ca77f5a19daecf1d1f71f73a5545905
11 changes: 11 additions & 0 deletions cli/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"github.com/coder/coder/coderd"
"github.com/coder/coder/coderd/database"
"github.com/coder/coder/coderd/database/databasefake"
"github.com/coder/coder/coderd/gitsshkey"
"github.com/coder/coder/coderd/tunnel"
"github.com/coder/coder/codersdk"
"github.com/coder/coder/provisioner/terraform"
Expand All @@ -57,6 +58,7 @@ func start() *cobra.Command {
useTunnel bool
traceDatadog bool
secureAuthCookie bool
sshKeygenAlgorithmRaw string
)
root := &cobra.Command{
Use: "start",
Expand Down Expand Up @@ -126,6 +128,12 @@ func start() *cobra.Command {
if err != nil {
return xerrors.Errorf("parse access url %q: %w", accessURL, err)
}

sshKeygenAlgorithm, err := gitsshkey.ParseSSHKeygenAlgorithm(sshKeygenAlgorithmRaw)
if err != nil {
return xerrors.Errorf("parse ssh keygen algorithm %s: %w", sshKeygenAlgorithmRaw, err)
}

logger := slog.Make(sloghuman.Sink(os.Stderr))
options := &coderd.Options{
AccessURL: accessURLParsed,
Expand All @@ -134,6 +142,7 @@ func start() *cobra.Command {
Pubsub: database.NewPubsubInMemory(),
GoogleTokenValidator: validator,
SecureAuthCookie: secureAuthCookie,
SSHKeygenAlgorithm: sshKeygenAlgorithm,
}

if !dev {
Expand Down Expand Up @@ -337,6 +346,8 @@ func start() *cobra.Command {
_ = root.Flags().MarkHidden("tunnel")
cliflag.BoolVarP(root.Flags(), &traceDatadog, "trace-datadog", "", "CODER_TRACE_DATADOG", false, "Send tracing data to a datadog agent")
cliflag.BoolVarP(root.Flags(), &secureAuthCookie, "secure-auth-cookie", "", "CODER_SECURE_AUTH_COOKIE", false, "Specifies if the 'Secure' property is set on browser session cookies")
cliflag.StringVarP(root.Flags(), &sshKeygenAlgorithmRaw, "ssh-keygen-algorithm", "", "CODER_SSH_KEYGEN_ALGORITHM", "ed25519", "Specifies the algorithm to user for generating ssh keys. "+
`Accepted values are "ed25519", "ecdsa", or "rsa4096"`)

return root
}
Expand Down