chore: improve error message for incorrect login type #8349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jul 7, 2023
coderd/userauth.go
Outdated
Comment on lines
1376
to
1385
| addedMsg := "" | ||
| if user.LoginType == database.LoginTypePassword { | ||
| addedMsg = " You can convert your account to use this login type by visiting your account settings." | ||
| } | ||
| return database.User{}, httpError{ | ||
| code: http.StatusForbidden, | ||
| msg: fmt.Sprintf("Incorrect login type, attempting to use %q but user is of login type %q", | ||
| params.LoginType, | ||
| user.LoginType, | ||
| ), | ||
| code: http.StatusForbidden, | ||
| renderStaticPage: true, | ||
| msg: "Incorrect login type", | ||
| detail: fmt.Sprintf("Attempting to use login type %q, but the user has the login type %q.%s", | ||
| params.LoginType, user.LoginType, addedMsg), |
There was a problem hiding this comment.
Would it make sense to dedupe this?
johnstcn
approved these changes
Jul 7, 2023
bpmct
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8345
Before
After
(link takes you to
/login)