chore: touch ups to wsproxy UX #8350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about allowing adding and deleting workspace proxies from UI? |
I am not opposed, but will not do in this PR. This PR is just for minor touchups that came up in a short meeting. |
|
I think making The delete is easier to add to the existing table. |
kylecarbs
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touchups
Changes
Small
*.try.codermessage.Wsproxy create text
Wsproxy help text in picker
Styling could be improved
Wsproxy confirm delete
Workspace proxy table details
Needs styling
Peek.2023-07-06.15-37.webm