fix(coderd): remove CREATE INDEX CONCURRENTLY from migrations
#8353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to cause deadlocks with parallel migrations, which is why migrations seem to fail with multiple coderds. ``` coder-db-1 | 2023-07-06 20:15:04.322 UTC [90] ERROR: deadlock detected coder-db-1 | 2023-07-06 20:15:04.322 UTC [90] DETAIL: Process 90 waits for ExclusiveLock on advisory lock [16384,0,4187539795,1]; blocked by process 89. coder-db-1 | Process 89 waits for ShareLock on virtual transaction 4/15; blocked by process 90. coder-db-1 | Process 90: SELECT pg_advisory_lock($1) coder-db-1 | Process 89: CREATE INDEX CONCURRENTLY workspace_resources_job_id_idx ON workspace_resources USING btree (job_id); coder-db-1 | coder-db-1 | 2023-07-06 20:15:04.322 UTC [90] HINT: See server log for query details. coder-db-1 | 2023-07-06 20:15:04.322 UTC [90] STATEMENT: SELECT pg_advisory_lock($1) ```
83a4977 to
21ad562
Compare
kylecarbs
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to cause deadlocks with parallel migrations, which is why migrations seem to fail with multiple coderds.
Fixes #8210