Skip to content

chore(Makefile): add test-race target #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2023
Merged

chore(Makefile): add test-race target #8357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c966cb
chore(Makefile): add test-race target
johnstcn Jul 7, 2023
40e362a
fixup! chore(Makefile): add test-race target
johnstcn Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,11 @@ test-postgres-docker:
done
.PHONY: test-postgres-docker

# Make sure to keep this in sync with test-go-race from .github/workflows/ci.yaml.
test-race: test-clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we wipe the test cache when we run via Makefile? Adding -count=1 should work the same and wouldn't trash the cache (e.g. for non-race tests).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update existing invocations to use -count=1 as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'll make a separate PR for that and we can debate in there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I think that would be preferable 👍🏻

gotestsum --junitfile="gotests.xml" -- -race ./...
.PHONY: test-race

test-clean:
go clean -testcache
.PHONY: test-clean