Skip to content

chore(Makefile): specify count=1 instead of cleaning test cache #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 7, 2023

From a discussion in #8357 (comment): we may wish to consider specifying --count=1 instead of cleaning the entire test cache.

@johnstcn johnstcn assigned johnstcn and mafredri and unassigned mafredri Jul 7, 2023
@johnstcn johnstcn requested review from mafredri and mtojek July 7, 2023 10:30
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe just drop a comment in the Makefile to underline the reason

johnstcn and others added 2 commits July 7, 2023 11:32
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@johnstcn johnstcn merged commit 4e42c33 into main Jul 7, 2023
@johnstcn johnstcn deleted the cj/go-test-count branch July 7, 2023 11:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants