Skip to content

feat(coderd): support ephemeral parameters #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: frontend
  • Loading branch information
mtojek committed Jul 7, 2023
commit 533dde394bb6a38d1de99e99bb8e0ea7e55bc93c
1 change: 1 addition & 0 deletions site/src/api/typesGenerated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,7 @@ export interface TemplateVersionParameter {
readonly validation_max?: number
readonly validation_monotonic?: ValidationMonotonicOrder
readonly required: boolean
readonly ephemeral: boolean
}

// From codersdk/templateversions.go
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const createTemplateVersionParameter = (
validation_monotonic: "increasing",
description_plaintext: "",
required: true,
ephemeral: false,
...partial,
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ RichParameters.args = {
icon: "/emojis/1f1e6-1f1fa.png",
},
],
ephemeral: false,
},
],
createWorkspaceErrors: {},
Expand Down
5 changes: 5 additions & 0 deletions site/src/testHelpers/entities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,7 @@ export const MockTemplateVersionParameter1: TypesGen.TemplateVersionParameter =
icon: "/icon/folder.svg",
options: [],
required: true,
ephemeral: false
}

export const MockTemplateVersionParameter2: TypesGen.TemplateVersionParameter =
Expand All @@ -936,6 +937,7 @@ export const MockTemplateVersionParameter2: TypesGen.TemplateVersionParameter =
validation_max: 3,
validation_monotonic: "increasing",
required: true,
ephemeral: false
}

export const MockTemplateVersionParameter3: TypesGen.TemplateVersionParameter =
Expand All @@ -951,6 +953,7 @@ export const MockTemplateVersionParameter3: TypesGen.TemplateVersionParameter =
validation_error: "No way!",
validation_regex: "^[a-z]{3}$",
required: true,
ephemeral: false
}

export const MockTemplateVersionParameter4: TypesGen.TemplateVersionParameter =
Expand All @@ -964,6 +967,7 @@ export const MockTemplateVersionParameter4: TypesGen.TemplateVersionParameter =
icon: "/icon/database.svg",
options: [],
required: true,
ephemeral: false
}

export const MockTemplateVersionParameter5: TypesGen.TemplateVersionParameter =
Expand All @@ -980,6 +984,7 @@ export const MockTemplateVersionParameter5: TypesGen.TemplateVersionParameter =
validation_max: 10,
validation_monotonic: "decreasing",
required: true,
ephemeral: false
}

export const MockTemplateVersionVariable1: TypesGen.TemplateVersionVariable = {
Expand Down