Skip to content

fix(cli/clistat): improve handling of cgroups with no limits #8373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 7, 2023

  • Correctly handle v2 cgroup with no memory limit set
  • Do not set Total on results where there is no limit set (cpu or mem)

Tested with the Docker starter template.

CGroupV2:

Screenshot 2023-07-07 at 15 24 02

CGroupv1 (apparently Docker containers under cgroupv1 have a 'default' memory limit set that raises automatically):

Screenshot 2023-07-07 at 15 27 28

Fixes #8371

@johnstcn johnstcn self-assigned this Jul 7, 2023
@johnstcn johnstcn requested review from mafredri and mtojek July 7, 2023 14:37
@johnstcn johnstcn changed the title fix(cli/clistat): better handle cgroups with no limits fix(cli/clistat): improve handling of cgroups with no limits Jul 7, 2023
@johnstcn johnstcn merged commit c1ab5cf into main Jul 7, 2023
@johnstcn johnstcn deleted the cj/pr8371 branch July 7, 2023 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAM Usage shows error with starter docker template
2 participants