Skip to content

feat(site): display build logs on workspace transitioning statuses #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 10, 2023
Merged

feat(site): display build logs on workspace transitioning statuses #8397

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b25e37f
Add base logs component
BrunoQuaresma Jul 7, 2023
efebe52
Add preferences control
BrunoQuaresma Jul 7, 2023
1354561
Add experiment
BrunoQuaresma Jul 10, 2023
e785943
Only display build logs on experiment active
BrunoQuaresma Jul 10, 2023
0b9b4a9
Fix enababled
BrunoQuaresma Jul 10, 2023
e9ec7a9
Fix local storage
BrunoQuaresma Jul 10, 2023
b20d519
Update site/src/utils/workspace.tsx
BrunoQuaresma Jul 10, 2023
9b14633
Fix storybook
BrunoQuaresma Jul 10, 2023
9840863
minor fix
BrunoQuaresma Jul 10, 2023
62927c0
Fix stories
BrunoQuaresma Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only display build logs on experiment active
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Jul 10, 2023
commit e785943c8fdb965cc00d6e63777fe6b2de512290
4 changes: 3 additions & 1 deletion site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,11 @@ export const WorkspaceReadyPage = ({
const { isWarningIgnored, ignoreWarning } = useIgnoreWarnings(user.id)
const buildLogs = useBuildLogs(workspace)
const localPreferences = useLocalPreferences()
const dashboard = useDashboard()
const shouldDisplayBuildLogs =
workspace.latest_build.job.error ||
localPreferences.getPreference("buildLogsVisibility") === "visible"
(localPreferences.getPreference("buildLogsVisibility") === "visible" &&
dashboard.experiments.includes("workspace_build_logs_ui"))
const canHideBuildLogs = workspace.latest_build.job.error === undefined

const {
Expand Down