Skip to content

do not merge: WIP provisionerd #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

do not merge: WIP provisionerd #84

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
48527f7
feat: Add parameter and jobs database schema
kylecarbs Jan 29, 2022
c7c7388
feat: Compute project build parameters
kylecarbs Jan 29, 2022
ace6248
Fix terraform provisioner
kylecarbs Jan 29, 2022
2bd0c42
feat: Add provisionerd protobuf definitions
kylecarbs Jan 29, 2022
d878c13
feat: Add provisionerd service
kylecarbs Jan 29, 2022
1e8c421
Improve provisioner testing
kylecarbs Jan 29, 2022
bc8c0e0
Add support for completing a job
kylecarbs Jan 29, 2022
5d16f2a
Use fork of terraform-exec for JSON output
kylecarbs Jan 29, 2022
ce4a9fb
Add logging to provision jobs
kylecarbs Jan 29, 2022
f2fcc25
Merge branch 'main' into provisionerservice
kylecarbs Jan 30, 2022
666529e
Fix linting
kylecarbs Jan 30, 2022
ab7fbec
Rename variables
kylecarbs Jan 30, 2022
342a9de
Merge branch 'main' into provisionerservice
kylecarbs Jan 31, 2022
c79653e
Add new query functions for storing project history logs
kylecarbs Jan 31, 2022
1f4dfc7
Add queries for workspace logs
kylecarbs Jan 31, 2022
ba3ce57
add workspace and project history parameters
kylecarbs Jan 31, 2022
c01860d
Update protobufs for logs
kylecarbs Jan 31, 2022
c440af4
Log streaming
kylecarbs Jan 31, 2022
b495991
Refactor provisionerd tests to disconnect from coderd
kylecarbs Feb 1, 2022
73bc4e6
Merge branch 'main' into provisionerservice
kylecarbs Feb 1, 2022
82a5750
Merge branch 'main' into provisionerservice
kylecarbs Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions coderd/coderd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ func New(options *Options) http.Handler {
projects := &projects{
Database: options.Database,
}
provisionerd := &provisionerd{
Database: options.Database,
}
users := &users{
Database: options.Database,
}
Expand All @@ -39,6 +42,7 @@ func New(options *Options) http.Handler {
})
r.Post("/login", users.loginWithPassword)
r.Post("/logout", users.logout)
r.Get("/provisionerd", provisionerd.listen)
Copy link
Contributor

@bryphe-coder bryphe-coder Jan 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At very first glance, I thought this was an endpoint the browser would listen to for updates over a socket - but after reading the PR, I realized this is for the provisionerd process to establish a socket connection with coderd.

It might be helpful to have a comment to this effect, like:

// Endpoint that facilitates connection with running `provisionerd` processes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should change the endpoint? I genuinely wasn't sure what to call this!

// Used for setup.
r.Post("/user", users.createInitialUser)
r.Route("/users", func(r chi.Router) {
Expand Down
Loading