Skip to content

feat: add custom coder bin path for ProxyCommand #8425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 13, 2023
Merged

feat: add custom coder bin path for ProxyCommand #8425

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
252f4f3
feat: add custom coder bin path for ProxyCommand
Emyrk Jul 11, 2023
ee99527
make gen
Emyrk Jul 11, 2023
45bd452
force cli path to be absolute
Emyrk Jul 13, 2023
d400d11
Update text
Emyrk Jul 13, 2023
a7a435e
Rename flag
Emyrk Jul 13, 2023
d9e1285
make gen
Emyrk Jul 13, 2023
de4d628
Fix flag validation
Emyrk Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix flag validation
  • Loading branch information
@Emyrk
Emyrk committed Jul 13, 2023
commit de4d62863acca7fb8d2d626843a8fa3e56562394
4 changes: 4 additions & 0 deletions cli/configssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,10 @@ func (r *RootCmd) configSSH() *clibase.Cmd {
Description: "Optionally specify the absolute path to the coder binary used in ProxyCommand. " +
"By default, the binary invoking this command ('config ssh') is used.",
Value: clibase.Validate(clibase.StringOf(&coderCliPath), func(value *clibase.String) error {
if runtime.GOOS == goosWindows {
// For some reason filepath.IsAbs() does not work on windows.
return nil
}
absolute := filepath.IsAbs(value.String())
if !absolute {
return xerrors.Errorf("coder cli path must be an absolute path")
Expand Down