Skip to content

feat(site): display version message #8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 13, 2023
Merged

feat(site): display version message #8435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5bc48df
Add base
BrunoQuaresma Jul 11, 2023
42643b6
Add more info to outdated tooltip
BrunoQuaresma Jul 11, 2023
3936a13
Fix link
BrunoQuaresma Jul 12, 2023
3496e4d
Fix test
BrunoQuaresma Jul 12, 2023
e01ac01
feat(coderd): allow template version message to be set to empty
mafredri Jul 12, 2023
273061a
fix(coderd): fix bug in template creation that resets the message
mafredri Jul 12, 2023
ebd8e0d
make gen
mafredri Jul 12, 2023
5904c6d
fix patch in template editor
mafredri Jul 12, 2023
9cdce40
fix comment
mafredri Jul 12, 2023
46ac0d6
Fix test
BrunoQuaresma Jul 12, 2023
434cf2b
Fix fmt
BrunoQuaresma Jul 12, 2023
4fff5e2
Fix storybook
BrunoQuaresma Jul 12, 2023
4d610e1
Merge branch 'main' into bq/add-version-message
BrunoQuaresma Jul 12, 2023
e4196c4
Merge branch 'main' into bq/add-version-message
BrunoQuaresma Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(coderd): allow template version message to be set to empty
  • Loading branch information
@mafredri
mafredri committed Jul 12, 2023
commit e01ac01a8ed812700a5115686050b96ac9a8815e
4 changes: 2 additions & 2 deletions coderd/templateversions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ func (api *API) patchTemplateVersion(rw http.ResponseWriter, r *http.Request) {
updateParams.Name = params.Name
}

if params.Message != "" {
updateParams.Message = params.Message
if params.Message != nil {
updateParams.Message = *params.Message
}

errTemplateVersionNameConflict := xerrors.New("template version name must be unique for a template")
Expand Down
65 changes: 65 additions & 0 deletions coderd/templateversions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,6 +1223,71 @@ func TestTemplateVersionPatch(t *testing.T) {
assert.NotEqual(t, updatedVersion.Name, version.Name)
})

t.Run("Update the message", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
user := coderdtest.CreateFirstUser(t, client)
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil, func(req *codersdk.CreateTemplateVersionRequest) {
req.Message = "Example message"
})
coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

wantMessage := "Updated message"
updatedVersion, err := client.UpdateTemplateVersion(ctx, version.ID, codersdk.PatchTemplateVersionRequest{
Message: &wantMessage,
})

require.NoError(t, err)
assert.Equal(t, wantMessage, updatedVersion.Message)
})

t.Run("Remove the message", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
user := coderdtest.CreateFirstUser(t, client)
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil, func(req *codersdk.CreateTemplateVersionRequest) {
req.Message = "Example message"
})
coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

wantMessage := ""
updatedVersion, err := client.UpdateTemplateVersion(ctx, version.ID, codersdk.PatchTemplateVersionRequest{
Message: &wantMessage,
})

require.NoError(t, err)
assert.Equal(t, wantMessage, updatedVersion.Message)
})

t.Run("Keep the message", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
user := coderdtest.CreateFirstUser(t, client)
wantMessage := "Example message"
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil, func(req *codersdk.CreateTemplateVersionRequest) {
req.Message = wantMessage
})
coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)

t.Log(version.Message)

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
defer cancel()

updatedVersion, err := client.UpdateTemplateVersion(ctx, version.ID, codersdk.PatchTemplateVersionRequest{
Message: nil,
})

require.NoError(t, err)
assert.Equal(t, wantMessage, updatedVersion.Message)
})

t.Run("Use the same name if a new name is not passed", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
Expand Down
4 changes: 2 additions & 2 deletions codersdk/templateversions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ type TemplateVersionVariable struct {
}

type PatchTemplateVersionRequest struct {
Name string `json:"name" validate:"omitempty,template_version_name"`
Message string `json:"message" validate:"omitempty"`
Name string `json:"name" validate:"omitempty,template_version_name"`
Message *string `json:"message,omitempty" validate:"omitempty,lt=1048577"`
}

// TemplateVersion returns a template version by ID.
Expand Down