Skip to content

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 12, 2023

Go was upgraded to version 1.20.6 in #8433, but it was missed at following places

  1. dogfood/Dockerfile
  2. .github/workflows/ci.yaml in fmt step
  3. .github/workflows/security.yaml
  4. .github/workflows/release.yaml

@matifali matifali self-assigned this Jul 12, 2023
cdr-bot[bot]
cdr-bot bot previously approved these changes Jul 12, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ❌ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali changed the title chore: upgrade go to version 1.20.6 in dogfood Dockerfile chore: upgrade go to version 1.20.6 in ci, release and security workflows and dogfood Dockerfile Jul 12, 2023
@matifali matifali requested a review from coadler July 12, 2023 12:23
@matifali matifali removed the hotfix label Jul 12, 2023
@cdr-bot cdr-bot bot dismissed their stale review July 12, 2023 12:24

This PR is no longer a hotfix.

@matifali matifali changed the title chore: upgrade go to version 1.20.6 in ci, release and security workflows and dogfood Dockerfile chore: upgrade go version to 1.20.6 Jul 12, 2023
@matifali
Copy link
Member Author

@mtojek I am not sure how I can update for nix.

@mtojek
Copy link
Member

mtojek commented Jul 12, 2023

This PR must go first: NixOS/nixpkgs#242949

@matifali
Copy link
Member Author

@mtojek Merging this as we can update nix later, or should we wait?

@coadler
Copy link
Contributor

coadler commented Jul 12, 2023

Since this is just a security patch, I don't think we need to wait.

@matifali matifali merged commit 765fd29 into main Jul 12, 2023
@matifali matifali deleted the matifali/dogfood-go-upgrade branch July 12, 2023 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants