remove interval none

coder · mafredri · Jul 21, 2023 · Jul 14, 2023 · Jul 18, 2023 · Jul 19, 2023
commit 056918ec969ff82748a07401ad7e86745af5626d
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/insights.go b/coderd/insights.go
@@ -196,7 +196,7 @@ func (api *API) insightsTemplates(rw http.ResponseWriter, r *http.Request) {
 		// to parse the time ourselves.
 		startTimeString = p.String(vals, "", "start_time")
 		endTimeString   = p.String(vals, "", "end_time")
-		intervalString  = p.String(vals, string(codersdk.InsightsReportIntervalNone), "interval")
+		intervalString  = p.String(vals, "", "interval")
 		templateIDs     = p.UUIDs(vals, []uuid.UUID{}, "template_ids")
 	)
 	p.ErrorExcessParams(vals)
@@ -224,7 +224,7 @@ func (api *API) insightsTemplates(rw http.ResponseWriter, r *http.Request) {
 	err := api.Database.InTx(func(db database.Store) error {
 		var err error
 
-		if interval != codersdk.InsightsReportIntervalNone {
+		if interval != "" {
 			dailyUsage, err = db.GetTemplateDailyInsights(ctx, database.GetTemplateDailyInsightsParams{
 				StartTime:   startTime,
 				EndTime:     endTime,
@@ -435,15 +435,15 @@ func parseInsightsStartAndEndTime(ctx context.Context, rw http.ResponseWriter, s
 
 func verifyInsightsInterval(ctx context.Context, rw http.ResponseWriter, intervalString string) (codersdk.InsightsReportInterval, bool) {
 	switch v := codersdk.InsightsReportInterval(intervalString); v {
-	case codersdk.InsightsReportIntervalDay, codersdk.InsightsReportIntervalNone:
+	case codersdk.InsightsReportIntervalDay, "":
 		return v, true
 	default:
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 			Message: "Query parameter has invalid value.",
 			Validations: []codersdk.ValidationError{
 				{
 					Field:  "interval",
-					Detail: fmt.Sprintf("must be one of %v", []codersdk.InsightsReportInterval{codersdk.InsightsReportIntervalNone, codersdk.InsightsReportIntervalDay}),
+					Detail: fmt.Sprintf("must be one of %v", []codersdk.InsightsReportInterval{codersdk.InsightsReportIntervalDay}),
 				},
 			},
 		})

diff --git a/codersdk/insights.go b/codersdk/insights.go
@@ -21,8 +21,7 @@ type InsightsReportInterval string
 
 // InsightsReportInterval enums.
 const (
-	InsightsReportIntervalNone InsightsReportInterval = "none"
-	InsightsReportIntervalDay  InsightsReportInterval = "day"
+	InsightsReportIntervalDay InsightsReportInterval = "day"
 )
 
 // UserLatencyInsightsResponse is the response from the user latency insights
@@ -109,7 +108,7 @@ type TemplateInsightsIntervalReport struct {
 	StartTime   time.Time              `json:"start_time" format:"date-time"`
 	EndTime     time.Time              `json:"end_time" format:"date-time"`
 	TemplateIDs []uuid.UUID            `json:"template_ids" format:"uuid"`
-	Interval    InsightsReportInterval `json:"interval" example:"day"`
+	Interval    InsightsReportInterval `json:"interval"`
 	ActiveUsers int64                  `json:"active_users" example:"14"`
 }
 
@@ -157,7 +156,7 @@ type TemplateInsightsRequest struct {
 	StartTime   time.Time              `json:"start_time" format:"date-time"`
 	EndTime     time.Time              `json:"end_time" format:"date-time"`
 	TemplateIDs []uuid.UUID            `json:"template_ids" format:"uuid"`
-	Interval    InsightsReportInterval `json:"interval" example:"day"`
+	Interval    InsightsReportInterval `json:"interval"`
 }
 
 func (c *Client) TemplateInsights(ctx context.Context, req TemplateInsightsRequest) (TemplateInsightsResponse, error) {

diff --git a/docs/api/schemas.md b/docs/api/schemas.md
@@ -2914,17 +2914,16 @@ AuthorizationObject can represent a "set" of objects, such as: all workspaces in
 ## codersdk.InsightsReportInterval
 
 ```json
-"none"
+"day"
 ```
 
 ### Properties
 
 #### Enumerated Values
 
-| Value  |
-| ------ |
-| `none` |
-| `day`  |
+| Value |
+| ----- |
+| `day` |
 
 ## codersdk.IssueReconnectingPTYSignedTokenRequest
 

diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -1590,8 +1590,8 @@ export const GitProviders: GitProvider[] = [
 ]
 
 // From codersdk/insights.go
-export type InsightsReportInterval = "day" | "none"
-export const InsightsReportIntervals: InsightsReportInterval[] = ["day", "none"]
+export type InsightsReportInterval = "day"
+export const InsightsReportIntervals: InsightsReportInterval[] = ["day"]
 
 // From codersdk/provisionerdaemons.go
 export type JobErrorCode =