Skip to content

feat(site): add build parameters option when starting or restarting a workspace #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 18, 2023
Merged

feat(site): add build parameters option when starting or restarting a workspace #8524

merged 15 commits into from
Jul 18, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2023-07-14 at 14 41 55

Close #8391

@BrunoQuaresma BrunoQuaresma requested a review from mtojek July 14, 2023 17:57
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 14, 2023
@coder coder deleted a comment from bpmct Jul 17, 2023
@coder coder deleted a comment from github-actions bot Jul 17, 2023
@coder coder deleted a comment from github-actions bot Jul 17, 2023
@matifali
Copy link
Member

matifali commented Jul 17, 2023 •
edited
Loading

/deploy-pr @bpmct @BrunoQuaresma

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

✔️ Deployed PR 8524 successfully.
🚀 Access the deployment link here.
⚠️ This deployment will be deleted when the PR is closed.

@BrunoQuaresma BrunoQuaresma requested review from mtojek and bpmct July 18, 2023 13:27
@bpmct
Copy link
Member

bpmct commented Jul 18, 2023

/deploy-pr

mtojek
mtojek approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@mtojek mtojek requested review from mtojek July 18, 2023 13:40
@mtojek mtojek self-requested a review July 18, 2023 13:40
@bpmct
Copy link
Member

bpmct commented Jul 18, 2023

LGTM!

@BrunoQuaresma BrunoQuaresma merged commit d12221c into main Jul 18, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/ephemeral-parameter branch July 18, 2023 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: handle ephemeral parameters
4 participants
@BrunoQuaresma @matifali @bpmct @mtojek