fix!: remove startup logs eof for streaming #8528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Jul 14, 2023
| if state.ReadyAt.Valid { | ||
| return | ||
| } | ||
| // Just keep listening - more logs might come in the future! |
There was a problem hiding this comment.
We can remove the ready state stuff higher up too.
|
@mafredri this can just wait until Monday, no biggie. |
We have external utilities like logstream-kube that may send logs after an agent shuts down unexpectedly to report additional information. In a recent change we stopped accepting these logs, which broke these utilities. In the future we'll rename startup logs to agent logs or something more generalized so this is less confusing in the future.
coadler
approved these changes
Jul 15, 2023
mafredri
approved these changes
Jul 17, 2023
|
Marked this as breaking since this will break coder server/clients (e.g. older clients will continue streaming startup logs forever, when blocking startup script is used). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have external utilities like logstream-kube that may send logs after an agent shuts down unexpectedly to report additional information. In a recent change we stopped accepting these logs, which broke these utilities.
In the future we'll rename startup logs to agent logs or something more generalized so this is less confusing in the future.