feat(cli): show workspace health in list #8541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought a boolean would be good, but on second thought. Perhaps we shouldn't show anything for a stopped workspace, thoughts? 
Edit: This is what it looks like now: 
|
mtojek
approved these changes
Jul 17, 2023
| @@ -51,12 +53,17 @@ func workspaceListRowFromWorkspace(now time.Time, usersByID map[uuid.UUID]coders | |||
| } | |||
| } | |||
|
|
|||
| healthy := "" | |||
There was a problem hiding this comment.
Technically, it could be covered with unit tests.
There was a problem hiding this comment.
Testing an individual column feels a bit overkill, I think this would be a good fit for a golden-file type test (we could do that for multiple commands).
Essentially, set up a server, some workspace and agents, a list of commands to run, and generate a golden file for each command.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6461