Skip to content

fix(site): fix bottom border on build logs #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(site): fix bottom border on build logs #8554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion site/src/components/Logs/Logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ const useStyles = makeStyles<
borderRadius: theme.shape.borderRadius,
overflowX: "auto",
background: theme.palette.background.default,
borderBottom: `1px solid ${theme.palette.divider}`,

"&:not(:last-child)": {
borderBottom: `1px solid ${theme.palette.divider}`,
borderRadius: 0,
},
},
scrollWrapper: {
minWidth: "fit-content",
Expand Down
32 changes: 18 additions & 14 deletions site/src/components/WorkspaceBuildLogs/WorkspaceBuildLogs.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
import { ComponentMeta, Story } from "@storybook/react"
import { MockWorkspaceBuildLogs } from "../../testHelpers/entities"
import {
WorkspaceBuildLogs,
WorkspaceBuildLogsProps,
} from "./WorkspaceBuildLogs"
import { Meta, StoryObj } from "@storybook/react"
import { WorkspaceBuildLogs } from "./WorkspaceBuildLogs"
import { MockWorkspaceBuildLogs } from "testHelpers/entities"

export default {
const meta: Meta<typeof WorkspaceBuildLogs> = {
title: "components/WorkspaceBuildLogs",
component: WorkspaceBuildLogs,
} as ComponentMeta<typeof WorkspaceBuildLogs>
}

export default meta

const Template: Story<WorkspaceBuildLogsProps> = (args) => (
<WorkspaceBuildLogs {...args} />
)
type Story = StoryObj<typeof WorkspaceBuildLogs>

export const InProgress: Story = {
args: {
logs: MockWorkspaceBuildLogs.slice(0, 20),
},
}

export const Example = Template.bind({})
Example.args = {
logs: MockWorkspaceBuildLogs,
export const Completed: Story = {
args: {
logs: MockWorkspaceBuildLogs,
},
}