Skip to content

fix(cli): unskip test and explicitly set --host in test cmd invocation #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

fix(cli): unskip test and explicitly set --host in test cmd invocation #8558

merged 3 commits into from
Jul 17, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 17, 2023 •
edited
Loading

  • Un-skips the test
  • Explicitly set --host flag when running the cli tests for the stat command as when these are invoked inside a container without a CPU or memory limit set, these tests may fail.

@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Jul 17, 2023
@johnstcn johnstcn self-assigned this Jul 17, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jul 17, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 56889d6 into main Jul 17, 2023
@johnstcn johnstcn deleted the cj/stat-mem-test-flake branch July 17, 2023 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn