Skip to content

feat(helm): add commandArgs for custom entrypoint #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2023
Merged

feat(helm): add commandArgs for custom entrypoint #8567

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9239c2d
feat(helm): add args conditional for custom entrypoint
ericpaulsen Jul 17, 2023
1d9598b
refactor: commandArgs
ericpaulsen Jul 17, 2023
e4dddde
add: nested conditional for wsproxy
ericpaulsen Jul 18, 2023
241866d
add: command_args test
ericpaulsen Jul 18, 2023
b3ae7d2
update helm test
deansheather Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add: nested conditional for wsproxy
  • Loading branch information
@ericpaulsen
ericpaulsen committed Jul 18, 2023
commit e4dddde91122a99c35ecff96a48ead12f6969dc2
8 changes: 6 additions & 2 deletions helm/templates/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,14 @@ spec:
command:
{{- toYaml .Values.coder.command | nindent 12 }}
args:
{{- if .Values.coder.workspaceProxy }}
{{- if .Values.coder.commandArgs }}
{{- toYaml .Values.coder.commandArgs | nindent 12 }}
{{- else }}
{{ if .Values.coder.workspaceProxy }}
- wsproxy
{{- end }}
- server
{{- end }}
{{- toYaml .Values.coder.commandArgs | nindent 12 }}
resources:
{{- toYaml .Values.coder.resources | nindent 12 }}
lifecycle:
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ coder:
# coder.command -- The command to use when running the Coder container. Used
# for customizing the location of the `coder` binary in your image.
command:
- /opt/coder server
- /opt/coder

# coder.commandArgs -- Set arguments for the entrypoint command of the Coder pod.
commandArgs: []
Expand Down