Skip to content

ci: fix release notes compare link #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

ci: fix release notes compare link #8581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e332b23
chore: fix release notes compare link
bpmct Jul 18, 2023
0bbc6d4
fix new version passed to release notes in release.yaml
mafredri Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
set -euo pipefail
ref=HEAD
old_version="$(git describe --abbrev=0 "$ref^1")"
version="$(./scripts/version.sh)"
version="v$(./scripts/version.sh)"

# Generate notes.
release_notes_file="$(mktemp -t release_notes.XXXXXX)"
Expand Down
3 changes: 3 additions & 0 deletions scripts/release/generate_release_notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ fi
if [[ -z $new_version ]]; then
error "No new version specified"
fi
if [[ $new_version != v* ]]; then
error "New version must start with a v"
fi
if [[ -z $ref ]]; then
error "No ref specified"
fi
Expand Down