Skip to content

feat: support localhost apps running https #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2023
Merged

feat: support localhost apps running https #8585

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ebe5a4
feat: support localhost apps running https
sreya Jul 19, 2023
3238edf
add a test
sreya Jul 19, 2023
56e2427
add wsconncache tests
sreya Jul 19, 2023
14e1ccd
lint
sreya Jul 19, 2023
bf67719
double comment
sreya Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
double comment
  • Loading branch information
@sreya
sreya committed Jul 19, 2023
commit bf677191d5c66c21f2674423f652e6792e0e57f2
10 changes: 5 additions & 5 deletions coderd/wsconncache/wsconncache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ func (c *Cache) Acquire(id uuid.UUID) (*Conn, func(), error) {
transport := defaultTransport.Clone()
transport.DialContext = agentConn.DialContext

// // We intentionally don't verify the certificate chain here.
// // The connection to the workspace is already established and most
// // apps are already going to be accessed over plain HTTP, this config
// // simply allows apps being run over HTTPS to be accessed without error --
// // many of which may be using self-signed certs.
// We intentionally don't verify the certificate chain here.
// The connection to the workspace is already established and most
// apps are already going to be accessed over plain HTTP, this config
// simply allows apps being run over HTTPS to be accessed without error --
// many of which may be using self-signed certs.
transport.TLSClientConfig = &tls.Config{
MinVersion: tls.VersionTLS12,
//nolint:gosec
Expand Down