Skip to content

feat: add single tailnet support to moons #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jul 19, 2023

This PR adds support for the single_tailnet experiment to moons. Instead of a websocket for each agent connection, it reuses the MultiAgent paradigm backed by a single websocket.

@coadler coadler self-assigned this Jul 19, 2023
@@ -395,35 +405,39 @@ func (api *API) updateEntitlements(ctx context.Context) error {
return nil
}

featureChanged := func(featureName codersdk.FeatureName) (changed bool, enabled bool) {
featureChanged := func(featureName codersdk.FeatureName) (initial, changed, enabled bool) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything below was pulled into a separate pr #8586

@coadler coadler requested a review from deansheather July 19, 2023 06:01
@deansheather
Copy link
Member

You commented Everything below was pulled into a separate pr https://github.com/coder/coder/pull/8586 but it looks like it's all still there

@coadler
Copy link
Contributor Author

coadler commented Jul 19, 2023

You commented Everything below was pulled into a separate pr https://github.com/coder/coder/pull/8586 but it looks like it's all still there

I pulled it out to get merged separately. My tests won't pass without it so I kept it in here until I could get it merged.

@coadler coadler merged commit 517fb19 into main Jul 19, 2023
@coadler coadler deleted the colin/singletailnet-moons branch July 19, 2023 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants