feat: synchronize oidc user roles #8595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User roles come from oidc claims. Prevent manual user role changes if set.
Emyrk
commented
Jul 19, 2023
| @@ -45,6 +45,7 @@ type User struct { | |||
| OrganizationIDs []uuid.UUID `json:"organization_ids" format:"uuid"` | |||
| Roles []Role `json:"roles"` | |||
| AvatarURL string `json:"avatar_url" format:"uri"` | |||
| LoginType LoginType `json:"login_type"` | |||
There was a problem hiding this comment.
coadler
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7470
What this does
Pulls the user's roles from the OIDC claims. Works almost identically to the group sync.
Role mapping is 1:many. So 1 role in OIDC can map to multiple coder roles.
A new entitlement was added to control this feature
Behaviors
rolesclaim is missing you will be demoted to a member. This is because there is no way to tell between an empty list claim and a missing claim. So turning on this feature with a bad OIDC config could revert all members on the site tomembers.Edit roles
You cannot manually assign roles to OIDC users since it is now controlled by this user role sync.
Users page
(@BrunoQuaresma might want to style this later)
Log message if extra roles provided