Skip to content

fix: prevent error log when pgcoord query is canceled #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2023
Merged

fix: prevent error log when pgcoord query is canceled #8609

merged 4 commits into from
Jul 19, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jul 19, 2023 •
edited
Loading

I believe this is what has been causing the TestReplicas flakes. There's a race condition where if a query was in flight while the pgcoord was closing, it would log an error. The error log then fails the test since somewhere along the line we're creating a slogtest logger.

2023-07-19T19:24:06.0298417Z     t.go:90: 2023-07-19 19:23:32.297 [erro]  pgcoord: failed to write binding to database  coordinator_id=a1483bf7-e24c-448d-bac0-9ce888b85ce2  client_id=00000000-0000-0000-0000-000000000000  agent_id=e1e3daed-4b0d-49c8-a9c9-17abc48811e5  node=""  error="pq: canceling statement due to user request"

@coadler
fix: prevent error log when pgcoord query is canceled.
97ac7b9 
I believe this is what has been causing the `TestReplicas` flakes.
There's a race condition where if a query was in flight while the
`pgcoord` was closing, it would log an error. The error log then fails
the test since somewhere along the line we're creating a `slogtest`
logger.
@coadler coadler self-assigned this Jul 19, 2023
@coadler coadler changed the title fix: prevent error log when pgcoord query is canceled. fix: prevent error log when pgcoord query is canceled Jul 19, 2023
@coadler coadler requested a review from sreya July 19, 2023 20:19
@coadler coadler enabled auto-merge (squash) July 19, 2023 20:29
@coadler coadler disabled auto-merge July 19, 2023 21:04
@coadler coadler merged commit 00b9a3c into main Jul 19, 2023
@coadler coadler deleted the colin/replica-flake branch July 19, 2023 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @sreya