fix(agent): check agent metadata every second instead of minute #8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is the fix for #8577. When looking at the websocket, metadata keys go over 2 minutes without updating, even when their interval is much lower. This fixes `reportMetadataLoop` to run every second and properly calculate the interval. A previous refactor set it to tick each minute instead of the previous behavior of each second.
mafredri
approved these changes
Jul 20, 2023
agent/agent.go
Outdated
| for { | ||
| // Ensure all backpressured metadata is posted. | ||
| if len(metadataResults) > 1 { | ||
| flushAllMetadata() |
There was a problem hiding this comment.
This could perhaps be moved to after the select below (i.e. when baseTicker.C is triggered). For now it seems to be doing the exact same thing as the select, except when baseTicker.C is triggered. (We probably don't need the len check either.)
There was a problem hiding this comment.
it doesn't really seem to be necessary, so i've just removed it for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the fix for #8577.
When looking at the websocket, metadata keys go over 2 minutes without updating, even when their interval is much lower. This fixes
reportMetadataLoopto run every second and properly calculate the interval. A previous refactor set it to tick each minute instead of the previous behavior of each second.