fix(scaletest): deploy external provisionerd #8618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Jul 20, 2023
scaletest/terraform/coder.tf
Outdated
| # Ref: https://github.com/coder/coder/issues/8243 | ||
| resource "local_file" "provisionerd_deployment" { | ||
| filename = "${path.module}/../.coderv2/provisionerd-deployment.yaml" | ||
| content = <<EOF |
There was a problem hiding this comment.
curious: can this be sourced from a regular YAML file?
There was a problem hiding this comment.
I think you can include it as a template, but I find it more straightforward to just inline.
There was a problem hiding this comment.
👍
My only concern is IDE support, but that is not affecting the product.
johnstcn
commented
Jul 20, 2023
mafredri
approved these changes
Jul 20, 2023
| resource "local_file" "provisionerd_deployment" { | ||
| filename = "${path.module}/../.coderv2/provisionerd-deployment.yaml" | ||
| content = <<EOF | ||
| apiVersion: apps/v1 |
There was a problem hiding this comment.
Consider formatting with prettier, just so it matches our other YAML?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other minor fixes: